-
Notifications
You must be signed in to change notification settings - Fork 211
try to use fugit::Duraction for CountDown::Time #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CHANGELOG.md
Outdated
@@ -19,9 +19,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|||
### Changed | |||
|
|||
- [breaking-change] use `fugit::Duraction` for `CountDown::Time` [#381] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: Duraction -> Duration (also in the PR title). Maybe add "instead of a frequency" to the line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
CHANGELOG.md
Outdated
@@ -19,9 +19,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|||
### Changed | |||
|
|||
- [breaking-change] use `fugit::Duraction` for `CountDown::Time` [#381] | |||
- [breaking-change] Remove all deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All deprecated what? 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't pay attention. Accidentally deleted in previous PR
f855b6d
to
31f26d0
Compare
551e2f7
to
1df2004
Compare
cc @andresv I've tried to implement |
@burrbull yes I think currently this is what must be done, It is a little bit inconvenient to use Also last time I read that |
Before port implementation to other HALs (and merge to this one), I must be sure it works as expected (I'm not sure it is so). |
Do you mean that |
I mean I need someone test this and told me if I made mistake. |
4527281
to
cf82cf0
Compare
Now it just adds new structs, so no breaking changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
bors r+
Not for SysTick for nowUse 1 microsecond as minimal timeout for SysTickCounter
This PR lets to use
fugit
units for timer including values bigger then 1 second.Sampling of timer (time of 1 tick) now can be set in by FREQ generic constant.