Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FCLite] Add FC Lite integration in FC Example app #4694

Merged
merged 4 commits into from
Mar 25, 2025

Conversation

mats-stripe
Copy link
Collaborator

Summary

Adds an entry point for FC Lite in our Financial Connections Example app. FC Lite currently isn't implemented, so this doesn't currently do anything, but it will come in handy for my next PRs that build out this integration.

Motivation

Will allow testing FC Lite once it's implemented.

Testing

Changelog

N/a

} else {
assertionFailure("unable to convert `configurationData` to a `configurationString`")
}
let configurationString = String(decoding: configurationData, as: UTF8.self)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by fix. Our linter was yelling about this line

@mats-stripe mats-stripe force-pushed the mats/fc_lite_interface_and_models branch from caeb5ea to 065992c Compare March 20, 2025 17:22
@mats-stripe mats-stripe force-pushed the mats/fc_lite_in_fc_example_app branch 2 times, most recently from ac4a6ca to e122ef5 Compare March 21, 2025 19:37
Base automatically changed from mats/fc_lite_interface_and_models to master March 21, 2025 20:50
tillh-stripe
tillh-stripe previously approved these changes Mar 21, 2025
@@ -37,11 +37,13 @@ final class PlaygroundConfiguration {
enum IntegrationType: String, CaseIterable, Identifiable, Hashable {
case standalone = "standalone"
case paymentElement = "payment_element"
case fcLite = "fc_lite"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking, but would it make sense to make FC Lite its own setting? This way, you can run both standalone and MPE with both full and lite SDKs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 1172475 - added it to the SDK type:

@mats-stripe mats-stripe merged commit 7a1da5a into master Mar 25, 2025
6 checks passed
@mats-stripe mats-stripe deleted the mats/fc_lite_in_fc_example_app branch March 25, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants