Skip to content

feat: add request timeout parameter #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dreinon opened this issue Jan 13, 2022 · 0 comments · Fixed by #75
Closed

feat: add request timeout parameter #72

dreinon opened this issue Jan 13, 2022 · 0 comments · Fixed by #75
Assignees
@leynier
Labels
enhancement New feature or request

Comments

@dreinon
Copy link
Contributor

dreinon commented Jan 13, 2022

With the current implementation, requests timeout in the http client (httpx) isn't set, so the default value of 5 seconds is used, which can be too little for some users.

To solve this, we could add a request timeout parameter somewhere to be passed directly to the http client request.

Refer here for more information about how to configure timeout in httpx.
@leynier leynier self-assigned this Jan 13, 2022
@leynier leynier changed the title Feat: Add request timeout parameter feat: add request timeout parameter Jan 13, 2022
@leynier leynier added the enhancement New feature or request label Jan 13, 2022
@leynier leynier mentioned this issue Jan 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leynier leynier

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add timeout as a parameter of clients supabase/postgrest-py
2 participants
@leynier @dreinon