Skip to content

feat: add timeout as a parameter of clients #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2022

Conversation

leynier
Copy link
Contributor

@leynier leynier commented Jan 15, 2022

This feature is for evicting the use of the default timeout of httpx. Resolve #72

This feature is for evicting the use of the default timeout of httpx.
@leynier leynier added the enhancement New feature or request label Jan 15, 2022
@leynier leynier requested a review from a team January 15, 2022 08:57
@codecov
Copy link

codecov bot commented Jan 15, 2022

Codecov Report

Merging #75 (22fd941) into master (7897d97) will increase coverage by 0.03%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   88.59%   88.62%   +0.03%     
==========================================
  Files          21       21              
  Lines         684      686       +2     
==========================================
+ Hits          606      608       +2     
  Misses         78       78              
Impacted Files Coverage Δ
postgrest_py/_async/client.py 73.52% <83.33%> (ø)
postgrest_py/_sync/client.py 73.52% <83.33%> (ø)
postgrest_py/__init__.py 100.00% <100.00%> (ø)
postgrest_py/base_client.py 91.66% <100.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7897d97...22fd941. Read the comment docs.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 16, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.97%.

Quality metrics Before After Change
Complexity 0.28 ⭐ 0.28 ⭐ 0.00
Method Length 19.19 ⭐ 20.54 ⭐ 1.35 👎
Working memory 4.42 ⭐ 4.72 ⭐ 0.30 👎
Quality 93.22% 92.25% -0.97% 👎
Other metrics Before After Change
Lines 178 222 44
Changed files Quality Before Quality After Quality Change
postgrest_py/init.py 94.51% ⭐ 94.18% ⭐ -0.33% 👎
postgrest_py/base_client.py 90.52% ⭐ 90.01% ⭐ -0.51% 👎
postgrest_py/_async/client.py 94.01% ⭐ 92.94% ⭐ -1.07% 👎
postgrest_py/_sync/client.py 94.05% ⭐ 92.98% ⭐ -1.07% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@leynier leynier requested a review from dreinon January 16, 2022 08:11
@leynier leynier merged commit 1ea965a into master Jan 16, 2022
@leynier leynier deleted the feat/add-timeout-parameter branch January 17, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add request timeout parameter
3 participants