-
-
Notifications
You must be signed in to change notification settings - Fork 56
feat: upsert with on-conflict support #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.52%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Co-authored-by: Anand <40204976+anand2312@users.noreply.github.com>
…angui/postgrest-py into feat/upsert-with-on-conflict
@anand2312 Could you give me a hand telling me what is missing? I'm not very knowledgeable with python repos. |
What is holding this one back? It would be a very nice feature to have! |
Waiting for someone to review the changes that @anand2312 requested. |
Sorry for the delay -- can you add some test cases for this case as well please? Otherwise this LGTM, ready to merge @Oisangui |
Think this should be good to go - if merged I'll add test in a FLUP |
Let's also pull in master and make sure the tests pass first though. |
Hey, @altryne noted - we'll merge by tomorrow evening if there are no major issues. Will validate this today evening + add necessary tests/ fixes. From now till then then I think the main workaround would be to use a sql func and an RPC call. Upd: Busy day, probably going to look at this tmrw instead |
Hey, I'm a little bit lost on where to use the on_conflict parameter in a request. Could you provide a simple example on how to use this parameter ? |
You are passing a list, it should be a string. |
Hum, I have this error even if I'm passing it as a string : |
on_conflict
support as described here https://postgrest.org/en/stable/api.html#on-conflict.Closes #139