Skip to content

fix!: schema method persisting only on current query #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

silentworks
Copy link
Contributor

What kind of change does this PR introduce?

The .schema() method from this library sets the schema as default, affecting the whole application instead of changing the schema of the current query only.

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

@coveralls
Copy link

coveralls commented Mar 2, 2025

Pull Request Test Coverage Report for Build 13610296600

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 95.504%

Totals Coverage Status
Change from base Build 13374160162: 0.01%
Covered Lines: 1742
Relevant Lines: 1824

💛 - Coveralls

grdsdev
grdsdev previously approved these changes Mar 2, 2025
@silentworks silentworks requested a review from grdsdev March 2, 2025 00:35
@silentworks silentworks changed the title fix: stop schema method persisting across all queries feat: schema method persisting only on current query Mar 2, 2025
@silentworks
Copy link
Contributor Author

silentworks commented Mar 2, 2025

This is a bug fix but it's also going to be a breaking change. Let's discuss before merging this PR. We also shouldn't create a release until we tighten the version constraints in the supabase-py repo.

@silentworks silentworks changed the title feat: schema method persisting only on current query fix!: schema method persisting only on current query Mar 11, 2025
@silentworks silentworks merged commit b0dd496 into main Mar 11, 2025
12 checks passed
@silentworks silentworks deleted the silentworks/fix-schema branch March 11, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supabase client .schema() change persists accross all instructions instead of the current one
3 participants