Skip to content

perf: sync configurations with gotrue-py #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

leynier
Copy link
Contributor

@leynier leynier commented Jan 4, 2022

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 4, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.05%.

Quality metrics Before After Change
Complexity 0.62 ⭐ 0.62 ⭐ 0.00
Method Length 23.88 ⭐ 23.91 ⭐ 0.03 👎
Working memory 5.44 ⭐ 5.45 ⭐ 0.01 👎
Quality 88.12% 88.07% -0.05% 👎
Other metrics Before After Change
Lines 684 701 17
Changed files Quality Before Quality After Quality Change
postgrest_py/init.py % 94.51% ⭐ %
postgrest_py/base_client.py 90.54% ⭐ 90.52% ⭐ -0.02% 👎
postgrest_py/base_request_builder.py 86.77% ⭐ 86.77% ⭐ 0.00%
postgrest_py/deprecated_client.py 96.89% ⭐ 96.89% ⭐ 0.00%
postgrest_py/deprecated_get_request_builder.py 95.34% ⭐ 95.34% ⭐ 0.00%
postgrest_py/types.py 81.03% ⭐ 80.78% ⭐ -0.25% 👎
postgrest_py/utils.py 95.74% ⭐ 95.74% ⭐ 0.00%
postgrest_py/_async/init.py % % %
postgrest_py/_async/client.py 94.01% ⭐ 94.01% ⭐ 0.00%
postgrest_py/_async/request_builder.py 88.17% ⭐ 88.17% ⭐ 0.00%
postgrest_py/_sync/init.py % % %
postgrest_py/_sync/client.py 94.05% ⭐ 94.05% ⭐ 0.00%
postgrest_py/_sync/request_builder.py 88.18% ⭐ 88.18% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@leynier leynier changed the title perf: sync configurations with gotrue py perf: sync configurations with gotrue-py Jan 4, 2022
@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@031cb5f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #66   +/-   ##
=========================================
  Coverage          ?   88.59%           
=========================================
  Files             ?       21           
  Lines             ?      684           
  Branches          ?        0           
=========================================
  Hits              ?      606           
  Misses            ?       78           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 031cb5f...10e7eb5. Read the comment docs.

@leynier leynier merged commit d5a97da into supabase:master Jan 4, 2022
@leynier leynier deleted the perf/sync-configurations-with-gotrue-py branch January 4, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant