dynamic env is an empty object in production when using config.kit.env.dir

[thenbe]

Describe the bug

config.kit.env.dir, introduced in #6175, only works in dev.

In dev, correct env is logged to console. In prod, empty object is logged to console. Minimal reproduction below.

Reproduction

https://github.com/ambiguous48/dynamic-env-missing

Logs

No response

System Info

System:
    OS: Linux 5.18 Pop!_OS 22.04 LTS
    CPU: (24) x64 12th Gen Intel(R) Core(TM) i9-12900K
    Memory: 16.68 GB / 31.13 GB
    Container: Yes
    Shell: 5.8.1 - /usr/bin/zsh
  Binaries:
    Node: 18.3.0 - ~/.local/share/pnpm/node
    Yarn: 1.22.19 - ~/.local/share/pnpm/yarn
    npm: 8.11.0 - ~/.local/share/pnpm/npm
  Browsers:
    Chrome: 104.0.5112.79
    Firefox: 103.0
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.65 
    @sveltejs/kit: next => 1.0.0-next.431 
    svelte: ^3.44.0 => 3.49.0 
    vite: ^3.0.4 => 3.0.9

Severity

annoyance

Additional Information

No response

[elliott-with-the-longest-name-on-github]

Based on my testing, this should be fixed with #6179. The problem isn't even the new config.kit.env.dir option, it's that (1) we weren't initializing the variables correctly in prerendering and (2) something something, complicated initialization sequences. Either way, the repro works fine when I point it at that branch.

[benmccann]

Closing this then since that PR has been merged. Note that it hasn't been released yet

[thenbe]

Note that it hasn't been released yet

@benmccann This is the release that you're referring to, yes? If the answer is no feel free to disregard this.

If it is, then the issue seems to still exist even after updating to the latest sveltekit (reproduction here).

[benmccann]

that reproduction looks to be on the latest version and any changes from a week ago have certainly been released by now, so I'd expect it to work

[elliott-with-the-longest-name-on-github]

I can't decide if this is intended behavior or not. On one hand, the dynamic env is populated by your adapter at runtime -- in this case, your "adapter" is SvelteKit...?

@Rich-Harris Do you think preview should respect config.kit.env.dir? I think my vote would be yes, but I want your blessing before doing anything with it.

[thenbe]

Just a heads up that this issue can also be reproduced when using adapter-node then running npm run build && node build/index.js

[elliott-with-the-longest-name-on-github]

Just a heads up that this issue can also be reproduced when using adapter-node then running npm run build && node build/index.js

This is definitely intended behavior.

[thenbe]

This is definitely intended behavior.

I had falsely assumed that $env/dynamic would automatically inject .env files (a la dotenv), despite the docs stating otherwise.

Please feel free to close this issue.

[elliott-with-the-longest-name-on-github]

This is definitely intended behavior.

I had falsely assumed that $env/dynamic would automatically inject .env files (a la dotenv), despite the docs stating otherwise.

Please feel free to close this issue.

It does in dev, obviously, but prod depends on the adapter. I'll wait to close until we hear from @Rich-Harris on whether the preview "adapter" should read .env files.