Backport REPL changes for Swift REPL completion fix #678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some environments (typically, buildbots), this variable may not be available. This can cause tests to behave differently. Explicitly set the variable to "vt100" to ensure consistent test behavior. It should not matter that we do not inherit the process TERM variable, as the child process runs in a new virtual terminal anyway.
…ong result By using m_cursor_index and not m_raw_cursor_pos in this function we return the characters until the argument index (not the character index). This means that for "foo" (cursor at the end of the string) this returns "" instead of "foo" (as the argument index is 0 for the first argument and not 4 which is the character index at the end). This lead to a crash in the REPL completion where it would cause that we would complete the string "ABC" to " " as we think the line is actually empty and we want to provide the indentation string. Note that the function has already been deleted upstream so this bug doesn't exist there.
|
@fredriss has to approve this. |
dcci
approved these changes
Jan 28, 2020
|
@swift-ci test |
|
@Teemperor are these commits upstream, and then cherry-picked? Doesn't look like it. |
|
[except for Pavel's] |
…tion code to old API Any REPL client should just move to CompletionRequest instead of relying on the translation code from the old API, so let's remove that translation code.
Teemperor
force-pushed
the
ChangeREPLForSwift
branch
from
34c1027 to
43978f8
Compare
|
Now the PR has:
|
fredriss
approved these changes
Jan 29, 2020
|
@swift-ci test macOS |
|
Alright, I'll merge this now and then check on the automerger and let's see how that goes. |
|
Please make sure to take those on the new stable branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those are the non-swift changes for #679
Pavel's commit is a back port. The change to the REPL interface is a commit I'll push tomorrow and the fix for the CompletionRequest is a new commit for this branch (as I already deleted the wrong code upstream).