Skip to content

[lldb][cmake] Fix relative path used for lldb executables #7359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2023
Merged

[lldb][cmake] Fix relative path used for lldb executables #7359

merged 1 commit into from
Aug 31, 2023

Conversation

finagolfin
Copy link
Member

I had this looking directly in ./swift/<os>/ before, but now that an installed lldb executable also links against Swift libraries, this needs to be the more general ../lib/swift/<os>/.

Pinging @rintaro and @JDevlieghere, should be an easy fix.

@finagolfin
[lldb][cmake] Fix relative path used for lldb executables
5444a68 
I had this looking directly in `./swift/<os>/` before, but now that an installed
lldb executable also links against Swift libraries, this needs to be the more
general `../lib/swift/<os>/`.
@rintaro
Copy link
Member

rintaro commented Aug 30, 2023

@swift-ci Please test

rintaro
rintaro approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@rintaro rintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rintaro rintaro mentioned this pull request Aug 30, 2023
Merged
@bnbarham bnbarham requested a review from JDevlieghere August 30, 2023 17:26
@bnbarham
Copy link

@swift-ci please test macOS platform

@finagolfin
Copy link
Member Author

I will submit this for next and stable/20230725 also in a couple minutes, looks like you already pulled it into 5.9 and 5.9.0.

This was referenced Aug 30, 2023
Merged
Merged
@finagolfin
Copy link
Member Author

Wow, the CI is getting aggressive at deleting results: the linux results just initiated 9 hours ago are gone.

@shahmishal, I figured the CI admins are having it delete old test results more aggressively in recent months, but deleting same-day results seems excessive. Could you dial these CI log deletions back to at least two weeks?

@shahmishal
Copy link
Member

It's gone because we had to restart Jenkins. Please re-request testing

@bnbarham
Copy link

It's gone because we had to restart Jenkins. Please re-request testing

@finagolfin can't request testing 😅

@bnbarham
Copy link

@swift-ci please test Linux platform

@finagolfin
Copy link
Member Author

All three pulls are failing because of the pre-existing issues on the CI, please merge them whenever you want, @bnbarham.

@bnbarham
Copy link

This one is gated, I'll wait until the fix is in, restart testing, and then merge them all 👍

@bnbarham
Copy link

@swift-ci please test Linux platform

@rintaro rintaro merged commit 89d8728 into swiftlang:stable/20221013 Aug 31, 2023
@finagolfin finagolfin deleted the stable/20221013 branch August 31, 2023 14:48
finagolfin added a commit to finagolfin/swift-integration-tests that referenced this pull request Aug 31, 2023
@finagolfin
Update the ELF liblldb.so runpath for swiftlang/llvm-project#7359
63d2f2c
bnbarham added a commit to swiftlang/swift-integration-tests that referenced this pull request Aug 31, 2023
@bnbarham
Merge pull request #121 from finagolfin/rpath
9ea8272 
Update the ELF liblldb.so runpath for swiftlang/llvm-project#7359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rintaro rintaro rintaro approved these changes

@bnbarham bnbarham bnbarham approved these changes

@JDevlieghere JDevlieghere Awaiting requested review from JDevlieghere

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@finagolfin @rintaro @bnbarham @shahmishal