When a sourcekitd diagnostics request fails, show the request error as a diagnostic on the source file #1886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s a diagnostic on the source file The missing diagnostics might be due to an error that the user can fix. Report it to them. Fixes swiftlang#1812 rdar://139514623
|
@swift-ci Please test |
bnbarham
approved these changes
Dec 13, 2024
|
I’d say let’s just enable this by default for now. If we discover that it’s more distracting than helpful, we would probably just revert this PR again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The missing diagnostics might be due to an error that the user can fix. Report it to them.
Fixes #1812
rdar://139514623