[android] Support building _CFPosixSpawnFileActionsChdir() for older Android APIs too
#5210
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
This pull has no effect outside Android: the linux CI appears broken right now, as prior CI runs for unrelated pulls fail with the same error. |
…r Android APIs too Phase out the existing Android scheme of adding different callbacks based on whether the posix_spawn APIs are there at runtime, by simply linking against them at compile-time instead if a build triple with API 28 or later is specified.
|
Updated this to actually build when the Android API is greater than 27 and added a default @marcprux and @compnerd, I've only tested the old callback scheme on my Android CI, as it builds against API 24, so if you two are building against API 28 or later, please build this and let me know what you think. |
|
@swift-ci test |
parkera
approved these changes
May 13, 2025
|
@swift-ci test |
|
I just built and tested this natively on Android against API 28, got the same test results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jakepetroules, following on the similar swiftlang/swift-llbuild#985, this gets Foundation building with older Android APIs too, which I've had to patch otherwise on my Android CI that builds against API 24.