[6.2] Fix ptrauth C++ module include issue between extern #5213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Kyle-Ye
commented
May 14, 2025
Kyle-Ye
commented
- Explanation: Fix a regression introduced when use CF here on Linux introduced by 6.1 release.
- Scope: header and module issue
- Issues: 5211
- Original PRs: Fix ptrauth C++ module include issue between extern #5212
- Risk: Low
- Testing: None
- Reviewers: @parkera
Fix “error: import of C++ module 'ptrauth' appears within extern "C" language linkage specification” LLVM upstream makes ptrauth a module on this commit swiftlang/llvm-project@0481f04. Swift 6.1 release introduced such change into the toolchain.
|
@swift-ci please test |
|
We're still planning on setting up a main-to-6.2 auto merger. @shahmishal who should we ping for help on that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.