Add support for load-pass-plugin option
#1472
Conversation
|
cc/ @artemcm, @lhames, @DougGregor. |
| @@ -435,6 +435,10 @@ extension Driver { | |||
| commandLine.appendFlag(.pluginPath) | |||
| commandLine.appendPath(pluginPathRoot.localPluginPath) | |||
| } | |||
|
|
|||
| if let passPluginPath = parsedOptions.getLastArgument(.loadPassPluginEQ) { | |||
There was a problem hiding this comment.
Could you please also guard this with:
isFrontendArgSupported(.loadPassPluginEQ)
There was a problem hiding this comment.
Guarded, thanks!
|
Please add a simple test that the flag is propagated to the expected |
antoniofrighetto
force-pushed
the
feature/load-pass-plugin
branch
from
d41ec65 to
916a707
Compare
|
Rebased to main, and added a test forwarding the options to the frontend, thanks! |
antoniofrighetto
force-pushed
the
feature/load-pass-plugin
branch
from
916a707 to
3128d28
Compare
|
Rebased to main, solved conflicts. |
antoniofrighetto
force-pushed
the
feature/load-pass-plugin
branch
from
3128d28 to
b6bb0f2
Compare
|
Ping @artemcm Is this ready to land? The test in swiftlang/swift#68985 (comment) was passing! |
Looks like this needs to resolve a merge conflict first. |
antoniofrighetto
force-pushed
the
feature/load-pass-plugin
branch
from
b6bb0f2 to
1e84ca9
Compare
|
@swift-ci test |
|
Seems like CI skipped theses builds. @artemcm Can we try that again please? |
|
@swift-ci test |
|
Gentle ping for merging this. |
antoniofrighetto
force-pushed
the
feature/load-pass-plugin
branch
from
1e84ca9 to
aa2d5fb
Compare
|
Rebased conflicts, kind ping for testing this again. |
|
@swift-ci test |
CI job for Windows seems to have passed (https://ci-external.swift.org/job/swift-driver-PR-windows/1145/), but status has not been reported. |
antoniofrighetto
force-pushed
the
feature/load-pass-plugin
branch
from
aa2d5fb to
f05c30a
Compare
|
Rebased to main, kindly to be tested again as CI job for Windows was skipped. |
`Options.swift` has been regenerated so as to include `load-pass-plugin` option as well.
antoniofrighetto
force-pushed
the
feature/load-pass-plugin
branch
from
f05c30a to
417489e
Compare
|
Very gentle ping to finalize swiftlang/swift#68985 here in the driver as well. The option was already included in 37b167b, this became mostly NFC testing the feature (cc/ @aschwaighofer). |
|
@swift-ci test |
| func testFrontendLoadPassPlugin() throws { | ||
| #if os(Windows) | ||
| throw XCTSkip("'-load-pass-plugin' is not available on Windows.") | ||
| #else |
There was a problem hiding this comment.
Why is this not available on Windows?
Options.swifthas been regenerated so as to includeload-pass-pluginoption as well.Frontend implementation at swiftlang/swift#68985.