-
Notifications
You must be signed in to change notification settings - Fork 43
WiX: rewrite the package identities #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Argue a bit on the naming: why not |
AMD64, IA32, and ARM64 are the Windows convention. |
I'd rather refer to MSVC instead of other Windows internal stuff: |
That too uses amd64 and arm64. The only difference is capitalization. |
|
Yeah, IA32 is not very common for user visible stuff and was introduced by Microsoft around the time of Itanium (IA64). It is referenced in a few places in documentation, so changing that to x86 might not be a bad idea. I'll do that in a bit. |
For the architecture/bitness portion of the name, since I can’t find clear consistent guidance from Microsoft, I’d like to propose “32-bit Intel”, “64-bit Intel”, “32-bit ARM”, and “64-bit ARM”. It makes it clear what it’s for without jargon. |
I like this - it makes it clear and avoids ambiguity. |
It’s actually pretty clear IMO. Microsoft refers to these three architectures in Visual Studio documentation as |
@etcwilde It’s untypical to refer to the x86 family as "Intel" on Windows. This makes sense only for Macs because Apple never used x86 CPUs from AMD and other manufacturers. It will certainly cause more confusion than clarity. |
@stevapple Microsoft does often refer to 64-bit Intel as AMD64 as well. 32-bit Intel: x86, Win32, IA-32, i686 I think I prefer either
|
FTR, the values that I had originally selected match the MSBuild
|
This should look more familiar for Windows users. They (and their case-insensitive variants) are seen in UWP, App Store, WinGet, NuGet, … as well as MSDN. |
I would say that the original variants are just as familiar: they are after all the values that Visual Studio/MSBuild use. |
Speaking as a long-time macOS and Linux dev who has spent only a middling amount of time on Windows, the architecture naming I'm most used to are
Reasoning:
|
FWIW, Visual Studio refers to them a I'm not a huge fan of all-caps ARM and AMD just because they look super similar (I guess the same can be said for So anyway, if we're looking for leads, we're probably never actually going to agree because nothing is consistent. My vote just to unblock things is to go with @gwynne and use
|
Restructure the packaging to be more homogeneous and concise. - Swift Software Development Kit * Swift Compiler Tools * Swift Developer Tools * Swift Windows Runtime (AMD64|ARM64|x86) * Swift Windows SDK (AMD64|ARM64|x86) This gives a more concise description that is also easier to understand and map. This sets up the path for further refinement of the installer to provide more control over the installed components. We do not suffix the Software Development Kit nor Compiler and Developer Tools as there will be a singular version that matches the host that is installed. Therefore, there is no value in differentiating that. However, multiple SDKs and Runtimes may be present, so identify the architecture for them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks fine
Restructure the packaging to be more homogeneous and concise.
This gives a more concise description that is also easier to understand
and map. This sets up the path for further refinement of the installer
to provide more control over the installed components.
We do not suffix the Software Development Kit nor Compiler and Developer
Tools as there will be a singular version that matches the host that is
installed. Therefore, there is no value in differentiating that.
However, multiple SDKs and Runtimes may be present, so identify the
architecture for them.