Skip to content

ICU: explicitly suffix tools for cross-compiling support #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2024

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented May 9, 2024

When cross-compiling to a different platform from Windows, we should explicitly suffix the executable binary for invocation.

When cross-compiling to a different platform from Windows, we should
explicitly suffix the executable binary for invocation.
@compnerd compnerd requested a review from hyp May 9, 2024 15:27
@compnerd compnerd requested review from shahmishal and tomerd as code owners May 9, 2024 15:27
Copy link
Contributor

@hyp hyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@compnerd compnerd merged commit 9ae81da into swiftlang:main May 13, 2024
@compnerd compnerd deleted the suffix branch May 13, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants