Skip to content

Revert "[icu] not building BUILD_DATA should still have an install ta… #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2024

Conversation

hyp
Copy link
Contributor

@hyp hyp commented May 13, 2024

…rget"

This reverts commit 4c12ddf.

Revert "[icu] add a BUILD_DATA flag to let android build skip building data"

This reverts commit 955e5a9.

This wasn't the right approach for ICU for android on Windows.

…rget"

This reverts commit 4c12ddf.

Revert "[icu] add a BUILD_DATA flag to let android build skip building data"

This reverts commit 955e5a9.
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused, shouldn't the install bits remain and the condition around it be removed? (along with the early return if BUILD_DATA is defined).

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline - there is a second copy of the install call at the end of the file that accomplishes this.

@hyp hyp merged commit 4dece97 into main May 13, 2024
@hyp hyp deleted the eng/revert-build-data branch May 13, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants