Skip to content

WiX: add SwiftMacros.dll to the image #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2024

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented May 15, 2024

This adds an additional DLL to the image. 'SwiftMacros.dll' includes macro implementations for stdlib. e.g. 'TaskLocal'

Resolves rdar://128092675.

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the minor tweak

Comment on lines 324 to 325
</ComponentGroup>
<ComponentGroup Id="SwiftMacros" Directory="_usr_bin">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</ComponentGroup>
<ComponentGroup Id="SwiftMacros" Directory="_usr_bin">

This adds an additional DLL to the image. 'SwiftMacros.dll' includes
macro implementations for stdlib. e.g. 'TaskLocal'
@rintaro rintaro force-pushed the wix-swiftmacrosdll branch from 6aab335 to 51d4aa8 Compare May 15, 2024 19:07
@rintaro rintaro merged commit cc57ac7 into swiftlang:main May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants