Skip to content

Set PYTHONIOENCODING for all lit tests #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2023
Merged

Set PYTHONIOENCODING for all lit tests #120

merged 1 commit into from
Sep 7, 2023

Conversation

bnbarham
Copy link
Contributor

Rather than the one-off hack in test-sourcekit-lsp.py, just set the IO encoding to UTF8 for all tests.

@bnbarham
Set PYTHONIOENCODING for all lit tests
038b201 
Rather than the one-off hack in `test-sourcekit-lsp.py`, just set the
IO encoding to UTF8 for all tests.
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham bnbarham mentioned this pull request Aug 30, 2023
Closed
@bnbarham
Copy link
Contributor Author

Toolchain build passed in the linked PR.

etcwilde
etcwilde approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@bnbarham bnbarham merged commit 7d6bf13 into swiftlang:main Sep 7, 2023
@bnbarham bnbarham deleted the set-python-encoding branch September 7, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etcwilde etcwilde etcwilde approved these changes

@shahmishal shahmishal shahmishal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bnbarham @etcwilde @shahmishal