Skip to content

Remove skipped tests on windows #8433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 task done
bkhouri opened this issue Mar 31, 2025 · 0 comments
Open
1 task done

Remove skipped tests on windows #8433

bkhouri opened this issue Mar 31, 2025 · 0 comments
Assignees
@bkhouri
Labels
bug test suite improvements to SwiftPM test suite windows

Comments

@bkhouri
Copy link
Contributor

bkhouri commented Mar 31, 2025

Is it reproducible with SwiftPM command-line tools: swift build, swift test, swift package etc?

  • Confirmed reproduction steps with SwiftPM CLI. The description text must include reproduction steps with either of command-line SwiftPM commands, swift build, swift test, swift package etc.

Description

With #8210 merged, and #8176 (add windows self-hosted pipeline) a required PR build, we need to remove as many skipped tests on Windows as possible, and raise GitHub issues for actual Windows platform issues.

Acceptance Criteria:

  • remove as many skipped tests on Windows as possible
  • a GitHub issue exists to track a tests that is skipped on Windows

Expected behavior

No response

Actual behavior

No response

Steps to reproduce

No response

Swift Package Manager version/commit hash

No response

Swift & OS version (output of swift --version ; uname -a)

No response
@bkhouri bkhouri added the bug label Mar 31, 2025
@bkhouri bkhouri self-assigned this Mar 31, 2025
@bkhouri bkhouri added windows test suite improvements to SwiftPM test suite labels Mar 31, 2025
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 1, 2025
@bkhouri
FIRST COMMIT: Enavbled all PathTests on Windows.. most still fail...
32713eb 
Fixes: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 3, 2025
@bkhouri
FIRST COMMIT: Enable all Windows tests and see which ones fails
a844b95 
Fixes: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 3, 2025
@bkhouri
FIRST COMMIT: Enable all Windows tests and see which ones fails
5fcc926 
Fixes: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 3, 2025
@bkhouri
Tests: Convert Basics/FileSystem/* to Swift Testing
f77a6f1 
Convert test from XCTest to Swift Testing.
  - Tests/BasicsTests/FileSystem/FileSystemTests.swift
  - Tests/BasicsTests/FileSystem/PathShimTests.swift
  - Tests/BasicsTests/FileSystem/PathTests.swift
  - Tests/BasicsTests/FileSystem/TemporaryFileTests.swift
  - Tests/BasicsTests/FileSystem/VFSTests.swift

relates to: swiftlang#8433
@bkhouri bkhouri mentioned this issue Apr 3, 2025
Closed
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 3, 2025
@bkhouri
FIRST COMMIT: Enable all Windows tests and see which ones fails
68d31b1 
Fixes: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 3, 2025
@bkhouri
Tests: Convert Basics/FileSystem/* to Swift Testing
304833a 
Convert test from XCTest to Swift Testing.
  - Tests/BasicsTests/FileSystem/FileSystemTests.swift
  - Tests/BasicsTests/FileSystem/PathShimTests.swift
  - Tests/BasicsTests/FileSystem/PathTests.swift
  - Tests/BasicsTests/FileSystem/TemporaryFileTests.swift
  - Tests/BasicsTests/FileSystem/VFSTests.swift

relates to: swiftlang#8433
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 3, 2025
@bkhouri
FIRST COMMIT: Enable all Windows tests and see which ones fails
0ad0aed 
Fixes: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 4, 2025
@bkhouri
FIRST COMMIT: Enable all Windows tests and see which ones fails
bcd4a5e 
Update the Basics/FileSystem/*.swift test to enable more tests that pass on Windows

- Update function name to get a sense of which tests are passing on Windows

Fixes: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 4, 2025
@bkhouri
FIRST COMMIT: Enable all Windows tests and see which ones fails
163886f 
Update the Basics/FileSystem/*.swift test to enable more tests that pass on Windows

- Update function name to get a sense of which tests are passing on Windows

Fixes: swiftlang#8433
Issue: rdar://148248105
Depends on: swiftlang#8448
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 4, 2025
@bkhouri
Tests: Convert Basics/FileSystem/* to Swift Testing
c7673b6 
Convert test from XCTest to Swift Testing.
  - Tests/BasicsTests/FileSystem/FileSystemTests.swift
  - Tests/BasicsTests/FileSystem/PathShimTests.swift
  - Tests/BasicsTests/FileSystem/PathTests.swift
  - Tests/BasicsTests/FileSystem/TemporaryFileTests.swift
  - Tests/BasicsTests/FileSystem/VFSTests.swift

relates to: swiftlang#8433
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 4, 2025
@bkhouri
FIRST COMMIT: Enable all Windows tests and see which ones fails
23744ec 
Update the Basics/FileSystem/*.swift test to enable more tests that pass on Windows

- Update function name to get a sense of which tests are passing on Windows

Fixes: swiftlang#8433
Issue: rdar://148248105
Depends on: swiftlang#8448
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 4, 2025
@bkhouri
FIRST COMMIT: Enable all Windows tests and see which ones fails
c8a2703 
Update the Basics/FileSystem/*.swift test to enable more tests that pass on Windows

- Update function name to get a sense of which tests are passing on Windows

Depends on: swiftlang#8448
Partially Addresses: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 4, 2025
@bkhouri
Tests: Enable more Windows Windows tests
eba83b8 
Enable more tests on Windows that are currently passing in
Basics/FileSystem/*.swift

Depends on: swiftlang#8448
Partially Addresses: swiftlang#8433
Issue: rdar://148248105
@bkhouri bkhouri mentioned this issue Apr 4, 2025
Open
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 4, 2025
@bkhouri
Tests: Enable more Windows Windows tests
bcda027 
Enable more tests on Windows that are currently passing in
Basics/FileSystem/*.swift

Depends on: swiftlang#8448
Partially Addresses: swiftlang#8433
Issue: rdar://148248105
@bkhouri bkhouri mentioned this issue Apr 7, 2025
Merged
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 8, 2025
@bkhouri
Tests: Enable some WorkspaceTests on Windows
eab58ee 
Enable WorkspaceTests on Windows that, for some reason, previously
failed.

Relates: swiftlang#8433
rdar://148248105
@bkhouri bkhouri mentioned this issue Apr 8, 2025
Merged
bkhouri added a commit that referenced this issue Apr 8, 2025
@bkhouri
Tests: Enabled SourceControlTests on Windows (#8453)
60976ee 
Some tests in Tests/SourceControlTests are passing on Windows since
upgrading the Git Version in the associated docker image, which was
completd in https://github.com/swiftlang/swift-docker/pulls/452

Enable the tests that are skipped.

Relates to: #8433 
rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 8, 2025
@bkhouri
Tests: Enable tests on Windows
8048d4c 
- Enable a few AsyncProcessTests
- Enable the lone skipped test in EnvironmentTests
- Enable all SourceKitLSPAPITests on Windows
- Replace usages of `fixwin` with `AbsolutePath.pathString`

Related to: swiftlang#8433
rdar://148248105
@bkhouri bkhouri mentioned this issue Apr 8, 2025
Merged
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 8, 2025
@bkhouri
Copy helper internally
99b2580 
Util $8223 is fixedd copy some helpers from IntergrationTests/Source/IntegrationTests
to Test/_InternalTestSupport so we can re-use the functionality.

Related to: swiftlang#8433
rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 8, 2025
@bkhouri
Copy helper internally
0d1f881 
Until $8223 is fixed copy some helpers from `IntergrationTests/Source/IntegrationTests``
to `Test/_InternalTestSupport` so we can re-use the functionality.

Related to: swiftlang#8433
rdar://148248105
@bkhouri bkhouri mentioned this issue Apr 8, 2025
Merged
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 8, 2025
@bkhouri
Tests: Convert Basics/FileSystem/* to Swift Testing
a07e0b1 
Convert test from XCTest to Swift Testing.
  - Tests/BasicsTests/FileSystem/FileSystemTests.swift
  - Tests/BasicsTests/FileSystem/PathShimTests.swift
  - Tests/BasicsTests/FileSystem/PathTests.swift
  - Tests/BasicsTests/FileSystem/TemporaryFileTests.swift
  - Tests/BasicsTests/FileSystem/VFSTests.swift

relates to: swiftlang#8433
@bkhouri bkhouri mentioned this issue Apr 14, 2025
Merged
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 15, 2025
@bkhouri
Test: Enable most AsyncProcessTests
38a7f2f 
Enable all but 3 tests.

Some AsyncProcessTests call to `cat` and `echo` commands.  Update the
executable to be called correctly on Windows via the `cmd.exe /c`
command, where the `cat` equivalent is `type`, which displays the file
contents.

Also, many tests call a script. We created a batch file, which simply
calls the associated script invoked by python.

Only 3 tests remain skipped.
- one failed assertion on Windows
- two otheers appear to have caused `swift test` tp hang.

Depends on: swiftlang#8495
Related to: swiftlang#8433
rdar://148248105
@bkhouri bkhouri mentioned this issue Apr 15, 2025
Open
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 15, 2025
@bkhouri
Copy helpers internally (swiftlang#8467)
3e145e2 
Until swiftlang#8223 is fixed copy some helpers from
`IntergrationTests/Source/IntegrationTests` to
`Test/_InternalTestSupport` so we can re-use the functionality.

Also, to workaround a Build preset issue, add a dependency on Swift
Testing when we are building using local dependencies.

Related to: swiftlang#8433
rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 15, 2025
@bkhouri
Test: Enable most AsyncProcessTests
a253651 
Enable all but 3 tests.

Some AsyncProcessTests call to `cat` and `echo` commands.  Update the
executable to be called correctly on Windows via the `cmd.exe /c`
command, where the `cat` equivalent is `type`, which displays the file
contents.

Also, many tests call a script. We created a batch file, which simply
calls the associated script invoked by python.

Only 3 tests remain skipped.
- one failed assertion on Windows
- two otheers appear to have caused `swift test` tp hang.

Depends on: swiftlang#8495
Related to: swiftlang#8433
rdar://148248105
@pmattos pmattos mentioned this issue Apr 15, 2025
Open
1 task
bkhouri added a commit that referenced this issue Apr 15, 2025
@bkhouri
Tests: Split SerializedJSONTests (#8496)
453e6d3 
Split the SerializedJSONTests into tests that pass and fail on Windows

Related: #8433
rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 16, 2025
@bkhouri
Tests: Enabled some BuildTests fon Windows
3eabbda 
- Enable the BuildPlanTests on Windows
- Split a PrepareForIndexTests tests into two withthe passing, and
  failing on Windows
- update/add a message on some skipped windows tests, with a reference
  to GitHub Issue

Related to: swiftlang#8433
rdar://148248105
@bkhouri bkhouri mentioned this issue Apr 16, 2025
Draft
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 16, 2025
@bkhouri
Copy helpers internally
5ece59a 
Until swiftlang#8223 is fixed copy some helpers from
`IntergrationTests/Source/IntegrationTests` to
`Test/_InternalTestSupport` so we can re-use the functionality.

Related to: swiftlang#8433
rdar://148248105

(cherry picked from commit e303b89)
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 16, 2025
@bkhouri
Tests: Convert Basics/FileSystem/* to Swift Testing
733b2b2 
Convert test from XCTest to Swift Testing.
  - Tests/BasicsTests/FileSystem/FileSystemTests.swift
  - Tests/BasicsTests/FileSystem/PathShimTests.swift
  - Tests/BasicsTests/FileSystem/PathTests.swift
  - Tests/BasicsTests/FileSystem/TemporaryFileTests.swift
  - Tests/BasicsTests/FileSystem/VFSTests.swift

relates to: swiftlang#8433
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 16, 2025
@bkhouri
Tests: Enable more Windows Windows tests
642e54c 
Enable more tests on Windows that are currently passing in
Basics/FileSystem/*.swift

Depends on: swiftlang#8448
Partially Addresses: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 16, 2025
@bkhouri
Copy helpers internally (swiftlang#8467)
ce35984 
Until swiftlang#8223 is fixed copy some helpers from
`IntergrationTests/Source/IntegrationTests` to
`Test/_InternalTestSupport` so we can re-use the functionality.

Also, to workaround a Build preset issue, add a dependency on Swift
Testing when we are building using local dependencies.

Related to: swiftlang#8433
rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 16, 2025
@bkhouri
Tests: Convert Basics/FileSystem/* to Swift Testing
2f93fcc 
Convert test from XCTest to Swift Testing.
  - Tests/BasicsTests/FileSystem/FileSystemTests.swift
  - Tests/BasicsTests/FileSystem/PathShimTests.swift
  - Tests/BasicsTests/FileSystem/PathTests.swift
  - Tests/BasicsTests/FileSystem/TemporaryFileTests.swift
  - Tests/BasicsTests/FileSystem/VFSTests.swift

relates to: swiftlang#8433
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 16, 2025
@bkhouri
Tests: Enable more Windows Windows tests
8754cfc 
Enable more tests on Windows that are currently passing in
Basics/FileSystem/*.swift

Depends on: swiftlang#8448
Partially Addresses: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 16, 2025
@bkhouri
Copy helpers internally (swiftlang#8467)
c0f4f8e 
Until swiftlang#8223 is fixed copy some helpers from
`IntergrationTests/Source/IntegrationTests` to
`Test/_InternalTestSupport` so we can re-use the functionality.

Related to: swiftlang#8433
rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 16, 2025
@bkhouri
Test: Enable most AsyncProcessTests
8312d6b 
Enable all but 3 tests.

Some AsyncProcessTests call to `cat` and `echo` commands.  Update the
executable to be called correctly on Windows via the `cmd.exe /c`
command, where the `cat` equivalent is `type`, which displays the file
contents.

Also, many tests call a script. We created a batch file, which simply
calls the associated script invoked by python.

Only 3 tests remain skipped.
- one failed assertion on Windows
- two otheers appear to have caused `swift test` tp hang.

Depends on: swiftlang#8495
Related to: swiftlang#8433
rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 21, 2025
@bkhouri
Copy helpers internally (swiftlang#8467)
f2a0006 
Until swiftlang#8223 is fixed copy some helpers from
`IntergrationTests/Source/IntegrationTests` to
`Test/_InternalTestSupport` so we can re-use the functionality.

Related to: swiftlang#8433
rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 21, 2025
@bkhouri
Tests: Convert Most Basics/FileSystem/* to Swift Testing
626d7bd 
Convert test from XCTest to Swift Testing.
  - Tests/BasicsTests/FileSystem/PathShimTests.swift
  - Tests/BasicsTests/FileSystem/PathTests.swift
  - Tests/BasicsTests/FileSystem/TemporaryFileTests.swift
  - Tests/BasicsTests/FileSystem/VFSTests.swift

relates to: swiftlang#8433
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 21, 2025
@bkhouri
Tests: Enable more Windows Windows tests
2913fce 
Enable more tests on Windows that are currently passing in
Basics/FileSystem/*.swift

Depends on: swiftlang#8448
Partially Addresses: swiftlang#8433
Issue: rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 22, 2025
@bkhouri
Test: Enable most AsyncProcessTests
c97ba8e 
Enable all but 3 tests.

Some AsyncProcessTests call to `cat` and `echo` commands.  Update the
executable to be called correctly on Windows via the `cmd.exe /c`
command, where the `cat` equivalent is `type`, which displays the file
contents.

Also, many tests call a script. We created a batch file, which simply
calls the associated script invoked by python.

Only 3 tests remain skipped.
- one failed assertion on Windows
- two otheers appear to have caused `swift test` tp hang.

Depends on: swiftlang#8495
Related to: swiftlang#8433
rdar://148248105
bkhouri added a commit to bkhouri/swift-package-manager that referenced this issue Apr 22, 2025
@bkhouri
Test: Enable most AsyncProcessTests
e73f6be 
Enable all but 3 tests.

Some AsyncProcessTests call to `cat` and `echo` commands.  Update the
executable to be called correctly on Windows via the `cmd.exe /c`
command, where the `cat` equivalent is `type`, which displays the file
contents.

Also, many tests call a script. We created a batch file, which simply
calls the associated script invoked by python.

Only 3 tests remain skipped.
- one failed assertion on Windows
- two otheers appear to have caused `swift test` tp hang.

Depends on: swiftlang#8495
Related to: swiftlang#8433
rdar://148248105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkhouri bkhouri

Labels
bug test suite improvements to SwiftPM test suite windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bkhouri