Exclude XCBuildSupport when building with CMake
#7358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XCBuildSupport is not available on non-Darwin platforms, especially Windows, where we have to have full CMake support at the moment. Maintaining XCBuildSupport in these unsupported configurations adds unnecessary overhead, especially in cases like #7258, where we have to add new dependencies only when `XCBuildSupport` is available. We should exclude from CMake builds to reduce this maintenance overhead.
MaxDesiatov
added
enhancement
build system
|
@swift-ci test |
MaxDesiatov
commented
Feb 22, 2024
| @@ -330,6 +334,9 @@ struct SwiftBootstrapBuildTool: ParsableCommand { | |||
| fileSystem: self.fileSystem, | |||
| observabilityScope: self.observabilityScope | |||
| ) | |||
| #else | |||
| fatalError("SwiftPM was built without XCBuild support") | |||
There was a problem hiding this comment.
This line is technically unreachable, since case .xcode is never reachable on non-Darwin platforms, and we don't call swift-bootstrap --build-system xcode anywhere during the build process on Darwin.
There was a problem hiding this comment.
This line is technically unreachable
Heh, famous last words:
https://ci.swift.org/job/oss-swift-package-macos/2753
--- bootstrap: note: Building SwiftPM (with a freshly built swift-bootstrap)
main/main.swift:345: Fatal error: SwiftPM was built without XCBuild support
There was a problem hiding this comment.
bootstrap/bin/swift-bootstrap ... --arch x86_64 --arch arm64 ...
And:
private var buildSystem: BuildSystemProvider.Kind {
#if os(macOS)
// Force the Xcode build system if we want to build more than one arch.
return self.architectures.count > 1 ? .xcode : .native
#else
// Force building with the native build system on other platforms than macOS.
return .native
#endif
}
compnerd
approved these changes
Feb 22, 2024
|
@swift-ci test |
|
@swift-ci test windows |
bnbarham
added a commit
to bnbarham/swift-package-manager
that referenced
this pull request
Feb 27, 2024
bnbarham
added a commit
to bnbarham/swift-package-manager
that referenced
this pull request
Feb 27, 2024
This was added to the `Package.swift` in swiftlang#7258 but skipped in the CMake because swiftlang#7358 excluded XCBuildSupport as a CMake target. But that's reverted here, so we need to add the dependency in.
MaxDesiatov
pushed a commit
that referenced
this pull request
Feb 27, 2024
…7371) This reverts commit 5287062, which causes macOS toolchain builds to fail with: ``` main/main.swift:345: Fatal error: SwiftPM was built without XCBuild support ``` Also adds the DriverSupport dependency to XCBuildSupport, which was skipped in #7258 because #7358 was merged (but we're reverting that).
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
XCBuildSupport is not available on non-Darwin platforms, especially Windows, where we have to have full CMake support at the moment. Maintaining XCBuildSupport in these unsupported configurations adds unnecessary overhead, especially in cases like swiftlang#7258, where we have to add new dependencies only when `XCBuildSupport` is available. We should exclude from CMake builds to reduce this maintenance overhead.
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
…7358)" (swiftlang#7371) This reverts commit 5287062, which causes macOS toolchain builds to fail with: ``` main/main.swift:345: Fatal error: SwiftPM was built without XCBuild support ``` Also adds the DriverSupport dependency to XCBuildSupport, which was skipped in swiftlang#7258 because swiftlang#7358 was merged (but we're reverting that).
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
XCBuildSupport is not available on non-Darwin platforms, especially Windows, where we have to have full CMake support at the moment. Maintaining XCBuildSupport in these unsupported configurations adds unnecessary overhead, especially in cases like swiftlang#7258, where we have to add new dependencies only when `XCBuildSupport` is available. We should exclude from CMake builds to reduce this maintenance overhead.
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
…7358)" (swiftlang#7371) This reverts commit 5287062, which causes macOS toolchain builds to fail with: ``` main/main.swift:345: Fatal error: SwiftPM was built without XCBuild support ``` Also adds the DriverSupport dependency to XCBuildSupport, which was skipped in swiftlang#7258 because swiftlang#7358 was merged (but we're reverting that).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XCBuildSupport is not available on non-Darwin platforms, especially Windows, where we have to have full CMake support at the moment. Maintaining XCBuildSupport in these unsupported configurations adds unnecessary overhead, especially in cases like #7258, where we have to add new dependencies only when
XCBuildSupportis available. We should exclude from CMake builds to reduce this maintenance overhead.