-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Implement per target swift version selection #7439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swift Forums pitch thread - https://forums.swift.org/t/pitch-swiftpm-swift-language-version-per-target/71067 Add a new Swift target setting API, similar to `enable{Upcoming, Experimental}Feature`, to specify a Swift language version that should be used to build the target, if such version is not specified, fallback to the current language version determination logic. Resolves: rdar://125732014
MaxDesiatov
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@swift-ci test |
@swift-ci please test |
@swift-ci please clean test macos |
jakepetroules
approved these changes
Apr 10, 2024
francescomikulis
approved these changes
Apr 10, 2024
@swift-ci please test windows platform |
xedin
added a commit
that referenced
this pull request
May 16, 2024
- Explanation: Implementation of SE-0435 proposal. Add a new Swift target setting API, similar to `enable{Upcoming, Experimental}Feature`, to specify a Swift language version that should be used to build the target, if such version is not specified, fallback to the current language version determination logic. - Scope: TargetDescription API and build system. - Main Branch PRs: #7439, #7544, #7550, #7557 - Radar: rdar://125732014 - Risk: Low - Reviewed By: @MaxDesiatov @bnbarham - Testing: Added new test-cases to the test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add to change log
build system
Changes to interactions with build systems
enhancement
package manifests
changes to package manifest APIs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift Forums pitch thread
Add a new Swift target setting API, similar to
enable{Upcoming, Experimental}Feature
,to specify a Swift language version that should be used to build the target, if such
version is not specified, fallback to the current language version determination logic.
Resolves: rdar://125732014