Skip to content

Implement per target swift version selection #7439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Apr 3, 2024

Swift Forums pitch thread

Add a new Swift target setting API, similar to enable{Upcoming, Experimental}Feature,
to specify a Swift language version that should be used to build the target, if such
version is not specified, fallback to the current language version determination logic.

Resolves: rdar://125732014

xedin added 2 commits April 3, 2024 14:26
Swift Forums pitch thread - https://forums.swift.org/t/pitch-swiftpm-swift-language-version-per-target/71067

Add a new Swift target setting API, similar to `enable{Upcoming, Experimental}Feature`,
to specify a Swift language version that should be used to build the target, if such
version is not specified, fallback to the current language version determination logic.

Resolves: rdar://125732014
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MaxDesiatov
Copy link
Contributor

@swift-ci test

@xedin
Copy link
Contributor Author

xedin commented Apr 4, 2024

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Apr 4, 2024

@swift-ci please clean test macos

@bnbarham
Copy link
Contributor

@swift-ci please test windows platform

@xedin xedin merged commit 73769de into swiftlang:main Apr 11, 2024
1 check passed
@MaxDesiatov MaxDesiatov added add to change log enhancement package manifests changes to package manifest APIs build system Changes to interactions with build systems labels Apr 30, 2024
xedin added a commit that referenced this pull request May 16, 2024
- Explanation:

Implementation of SE-0435 proposal.

Add a new Swift target setting API, similar to `enable{Upcoming,
Experimental}Feature`,
to specify a Swift language version that should be used to build the
target, if such
version is not specified, fallback to the current language version
determination logic.

- Scope: TargetDescription API and build system.

- Main Branch PRs:
#7439,
#7544,
#7550,
#7557

- Radar: rdar://125732014

- Risk: Low

- Reviewed By: @MaxDesiatov @bnbarham 

- Testing: Added new test-cases to the test suite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to change log build system Changes to interactions with build systems enhancement package manifests changes to package manifest APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants