Unskip all BuildPlanSwiftBuildTests for Swift Build #8503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmattos
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
bkhouri
approved these changes
Apr 15, 2025
bkhouri
requested changes
Apr 15, 2025
bkhouri
reviewed
Apr 15, 2025
| @@ -6996,27 +6998,19 @@ class BuildPlanSwiftBuildTests: BuildPlanTestCase { | |||
| try await super.testDuplicateProductNamesWithNonDefaultLibsThrowError() | |||
| } | |||
|
|
|||
| override func testTargetsWithPackageAccess() async throws { | |||
There was a problem hiding this comment.
praise: I love seeing tests added/re-enabled. party🎉
Hmm, I don't think we ran CI in this one Sam. BTW, this is still stacked on this other PR #8454. |
bkhouri
approved these changes
Apr 15, 2025
|
@swift-ci test |
pmattos
force-pushed
the
pmattos/new-pif-builder-in-SwiftBuildSupport
branch
5 times, most recently
from
04e20e5 to
db5124f
Compare
Base automatically changed from
pmattos/new-pif-builder-in-SwiftBuildSupport
to
main
April 17, 2025 08:03
pmattos
force-pushed
the
pmattos/unskip-BuildPlanSwiftBuildTests
branch
from
586a83f to
cffbb4a
Compare
|
@swift-ci please test |
|
@swift-ci test self hosted windows |
|
@swift-ci test windows |
|
@swift-ci test linux |
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Increase test coverage for the new PIF builder (for Swift Build).
Modifications:
Enable/unskip all tests in
BuildPlanSwiftBuildTestswhen using Swift Build.testTargetsWithPackageAccess
The build error logging, when using
--build-system swiftbuild, redirects all build tasks command lines toObservabilityScope, including those checked by this test. These are then redirected to stderr together with all other logging. I feel this makes sense, providing a nice flexibility when filtering theswift buildoutput, etc.Conversely, the
--build-system nativesends the build tasks command lines to stdout instead.As such, this updates the
testTargetsWithPackageAccessto reflect that.Result:
All
BuildPlanSwiftBuildTestsare now green on macOS; and just 1 test is skipped on Linux and Windows.