Skip to content

Skip failing test in TestCommandTests.swift #8553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

Skip failing test in TestCommandTests.swift #8553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Tests/CommandsTests/TestCommandTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,6 +577,7 @@ class TestCommandTestCase: CommandsBuildProviderTestCase {
}

func testFatalErrorDisplayedCorrectNumberOfTimesWhenSingleXCTestHasFatalErrorInBuildCompilation() async throws {
try XCTSkipIfCI()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the PR description, this is only failing on Amazon Linux 2, but the test is being disabled for all platform - this is less than ideal.

Can we follow an approach similar to #8546 to disable test only on platforms where tests are failing?

// Test for GitHub Issue #6605
// GIVEN we have a Swift Package that has a fatalError building the tests
let expected = 1
Expand Down