Make SwiftSDKMetadataV4.sdkRootPath optional #8687
Open
+7
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the "sdkRootPath" property of
swift-sdk.json
optional.Motivation:
The Android SDK bundle (swiftlang/swift#80788) does not include the Android NDK's sysroot in the bundle itself, but instead relies on it being installed locally. The install location will vary, and the user will be able to configure it with a command (modulo #8584) like:
However, since the
SwiftSDKMetadataV4.sdkRootPath
property is declared as non-optional, some value must be included in theswift-sdk.json
file.@MaxDesiatov at swiftlang/swift#80788 (comment) mentions:
Modifications:
Change
SwiftSDKMetadataV4.sdkRootPath
fromString
toString?
Result:
The swift-sdk.json can now contain destinations that do not specify a
sdkRootPath
property.