Disable inner code completion results (+ a little refactoring) #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of the definitions were used by the stress tester. Probably became obsolute through some refactoring.
I believe the original file was automatically generated and later maintained by hand whenever a UID was needed. Automate the generation at least for those UIDs that are currently defined in UIDs.py of the main swift repo.
|
@swift-ci Please test |
bnbarham
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #171, disable inner code completion results, which are slowing down code completion performance measurements.
While making the change, I noticed that the corresponding UIDs were missing from UIDs.swift. Instead of just adding them, I created a script that generates the majority of the file from UIDs.py in the main swift repo.
While doing that I noticed that SwiftSourceKit.swift was using UIDs that are no longer supported by SourceKit (specifically the syntax tree serialization format) but since none of the definitions in the file were used, I just deleted it.