Skip to content

Rename AccessPathSyntax to ImportPathSyntax #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ahoppen opened this issue May 2, 2023 · 3 comments · Fixed by #1638
Closed

Rename AccessPathSyntax to ImportPathSyntax #1632

ahoppen opened this issue May 2, 2023 · 3 comments · Fixed by #1638
Assignees
@whiteio
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ahoppen
Copy link
Member

ahoppen commented May 2, 2023

Address this Fix-It.

https://github.com/apple/swift-syntax/blob/2179d9fe6335c54e2fb13419c1186ac549d407c2/CodeGeneration/Sources/SyntaxSupport/DeclNodes.swift#L33

Also rename any properties named accessPath. To keep existing clients building, provide a type alias that maps AccessPathSyntax to ImportPathSyntax and deprecated methods for accessPath to SwiftSyntaxCompatibility.swift
@ahoppen ahoppen added enhancement New feature or request good first issue Good for newcomers labels May 2, 2023
@ahoppen ahoppen mentioned this issue May 2, 2023
Merged
@ahoppen
Copy link
Member Author

ahoppen commented May 2, 2023

Tracked in Apple’s issue tracker as rdar://108812214

@whiteio
Copy link
Contributor

whiteio commented May 3, 2023

@ahoppen Is it ok if I work on this one?

@ahoppen
Copy link
Member Author

ahoppen commented May 3, 2023

That would be great

@whiteio whiteio mentioned this issue May 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whiteio whiteio

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename AccessPathSyntax to ImportPathSyntax whiteio/swift-syntax
2 participants
@ahoppen @whiteio