Rename AccessPathSyntax to ImportPathSyntax

[whiteio]

AccessPathSyntax should be renamed to ImportPathSyntax. This PR renames AccessPath to ImportPath, AccessPathComponent to ImportPathComponent, generates the code and adds the following type aliases to keep existing clients building:

• AccessPathBuilder -> ImportPathBuilder
• AccessPathSyntax -> ImportPathSyntax
• AccessPathComponentSyntax -> ImportPathComponentSyntax

Resolves #1632

[ahoppen]

Thanks. This looks great to me. ✅

I left a few review comments for myself because this will somewhat become the blueprint of which compatibility functions we need to create when renaming a syntax node kind and I want to keep track of where we intentionally continue to break source compatibility (which is fine, we just want to minimize the impact as much as possible).

[ahoppen]

Note to myself (no action required on your side) since this is the first time we are trying to do a rename while maintaining source compatibility as much as possible and I’m trying to assess where source breakages might occur.

We can’t rename a type without also renaming the case in SyntaxEnum. I think that it might be fine because there are way fewer people switching over a SyntaxEnum than there are using the type names.

[ahoppen]

Same here, just a note to myself, no action required on your side: This is not source compatible if we are renaming a syntax node’s type name. We might be able to mitigate this by defining a static member on SyntaxKind as follows

public extension SyntaxKind {
  @available(*, deprecated, renamed: "importPath")
  var accessPath: SyntaxKind { .importPath }
}

This way we will only break clients that are exhaustively switching over SyntaxKind, which is fairly unlikely since the enum is so huge.

[ahoppen]

@swift-ci Please test

[whiteio]

@ahoppen The failing CI checks don't seem to be related to the changes in the PR, could you re-run the checks please?

[kimdv]

@swift-ci please test