[Windows] Avoid linking with swiftWinSDK.dll #2685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
compnerd
approved these changes
Jun 14, 2024
rintaro
commented
Jun 14, 2024
rintaro
force-pushed
the
windows-no-swiftwinsdk
branch
from
fb89ed1 to
d088cbe
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
rintaro
force-pushed
the
windows-no-swiftwinsdk
branch
from
d088cbe to
3efa236
Compare
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
Avoid 'import WinSDK' in swift sources or `#include` in headers. This is to avoid linking with Swift overlay library (swiftWinSDK.dll) so swift-frontend with plugins won't depends on it.
rintaro
force-pushed
the
windows-no-swiftwinsdk
branch
from
3efa236 to
d360086
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
|
swiftlang/swift#74439 |
|
swiftlang/swift#74439 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid
import WinSDKin swift sources or#includein headers. This is to avoid linking with Swift overlay library (swiftWinSDK.dll) so swift-frontend with plugins won't depend on it.