Skip to content

[6.0][CMake] Add option to set the target namespace #2702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[6.0][CMake] Add option to set the target namespace #2702

wants to merge 1 commit into from

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jun 25, 2024

Cherry-pick #2659 into release/6.0

  • Explanation: For CMake builds, make an option SWIFTSYNTAX_TARGET_NAMESPACE to add a prefix to module names in the package. Also add SWIFTSYNTAX_EMIT_MODULE option for build library-evolution enabled modules with .swiftinterface. To keep the current behavior, this option is TRUE unless it's explicitly specified to NO
  • Scope: CMake builds
  • Risk: Low. This adds a couple of CMake settings, but keeping the default behavior as-is.
  • Testing: Passes the current test suite
  • Issue: preparation for rdar://130532628
  • Reviewer: Hamish Knight (@hamishknight)

@rintaro
[CMake] Add option to set the target namespace
e479843 
Each target name is prefixed with SWIFTSYNTAX_TARGET_NAMESPACE

Also, add SWIFTSYNTAX_EMIT_MODULE setting; 'true' for building
library-evolution enabled modules with .swiftinterface, 'false' for
building fragile modules, undefined is 'true'

(cherry picked from commit 4e7bb71)
@rintaro rintaro requested review from ahoppen and bnbarham as code owners June 25, 2024 21:32
@rintaro
Copy link
Member Author

rintaro commented Jun 25, 2024

@swift-ci Please test

This was referenced Jun 26, 2024
Closed
Closed
Closed
@rintaro rintaro closed this Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen Awaiting requested review from ahoppen ahoppen is a code owner

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rintaro