Skip to content

Minor fixes and cleanups for SwiftIfConfig diagnostics #2783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2024
Merged

Minor fixes and cleanups for SwiftIfConfig diagnostics #2783

merged 2 commits into from
Aug 7, 2024

Conversation

DougGregor
Copy link
Member

@DougGregor DougGregor commented Aug 7, 2024 •
edited
Loading

This covers two changes:

  • Make sure we diagnostic a spurious label on build conditions that have a single unlabeled argument (oops)
  • Make sure we consistently quote build condition names in diagnostics (it was a mix before)

@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor DougGregor enabled auto-merge August 7, 2024 15:57
@DougGregor DougGregor mentioned this pull request Aug 7, 2024
Merged
@DougGregor DougGregor merged commit 28794d2 into swiftlang:main Aug 7, 2024
3 checks passed
@DougGregor DougGregor deleted the ifconfig-diag-cleanup branch August 7, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DougGregor @ahoppen