Remove C++-based section discovery logic. #902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the C++ _section_ discovery logic that's used to look up Swift's type metadata sections. Instead, we reuse the new logic used for test content sections (written in Swift.)
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
grynspan
commented
Jan 9, 2025
| @@ -40,19 +53,12 @@ const void *_Nonnull const SWTTestContentSectionBounds[2] = { | |||
| #include <atomic> | |||
There was a problem hiding this comment.
I can probably strip down these includes now, but will leave that for another PR.
|
@swift-ci test |
|
@swift-ci test Windows |
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test Windows |
|
@swift-ci test |
Co-authored-by: Stuart Montgomery <smontgomery@apple.com>
stmontgomery
approved these changes
Jan 10, 2025
grynspan
added
the
less-c++
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the C++ section discovery logic that's used to look up Swift's type metadata sections. Instead, we reuse the new logic used for test content sections (written in Swift.)
I did not attempt to translate to Swift the logic to extract Swift types from Swift's metadata records. This logic relies pretty heavily on precise C++ data structure layouts and uses pointer authentication as well as relative pointers. Swift does not guarantee the same structure layout as C++, nor does it provide API for pointer authentication, nor do value types in Swift have stable addresses that can be used to compute addresses from relative offsets.
Resolves #764.
Checklist: