Skip to content

Handle strerror_r return type of UnsafeMutablePointer<CChar> for Android #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Sources/TSCBasic/misc.swift
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,12 @@ extension SystemError: CustomStringConvertible {
var cap = 64
while cap <= 16 * 1024 {
var buf = [Int8](repeating: 0, count: cap)
#if os(Android)
let errptr: UnsafeMutablePointer<CChar> = TSCLibc.strerror_r(errno, &buf, buf.count)
let err = Int(errptr.pointee)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem right. I think that this is missing a wrapper (is strerror_r implemented as a macro?

#else
let err = TSCLibc.strerror_r(errno, &buf, buf.count)
#endif
if err == EINVAL {
return "Unknown error \(errno)"
}
Expand Down