Skip to content

Disable expected SILOptimizer test failures. #28054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 0 additions & 48 deletions test/IRGen/copy_value_destroy_value.sil

This file was deleted.

3 changes: 0 additions & 3 deletions test/SILOptimizer/OSLogConstantEvaluableTest.swift
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@
//
// REQUIRES: OS=macosx || OS=ios || OS=tvos || OS=watchos

// TODO(TF-799): Re-enable test after SR-11336 is fixed.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this test has been re-enabled because it has started to pass.

// XFAIL: *

// Test that the functions defined in the OSLogPrototype overlay annotated as
// constant evaluable are so (with the constexpr-limit defined above).
// This test is meant to catch regressions in the OSLog overlay implementation
Expand Down
4 changes: 4 additions & 0 deletions test/SILOptimizer/OSLogPrototypeCompileTest.swift
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
// whether specific compile-time constants such as the format string,
// the size of the byte buffer etc. are literals after the mandatory pipeline.

// SWIFT_ENABLE_TENSORFLOW
// TODO(TF-799): Re-enable test after SR-11336 is fixed.
// XFAIL: *

import OSLogPrototype

if #available(OSX 10.12, iOS 10.0, watchOS 3.0, tvOS 10.0, *) {
Expand Down
1 change: 1 addition & 0 deletions test/SILOptimizer/constant_evaluable_subset_test.swift
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
//
// RUN: %FileCheck %s < %t/error-output-mandatory

// SWIFT_ENABLE_TENSORFLOW
// TODO(TF-799): Re-enable test after SR-11336 is fixed.
// XFAIL: *

Expand Down
4 changes: 4 additions & 0 deletions test/SILOptimizer/constant_propagation_diagnostics.swift
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
// RUN: %target-swift-frontend -emit-sil -sdk %S/../SILGen/Inputs %s -o /dev/null -verify
// RUN: %target-swift-frontend -enable-ownership-stripping-after-serialization -emit-sil -sdk %S/../SILGen/Inputs %s -o /dev/null -verify

// SWIFT_ENABLE_TENSORFLOW
// TODO(TF-799): Re-enable test after SR-11336 is fixed.
// XFAIL: *

// <rdar://problem/18213320> enum with raw values that are too big are not diagnosed
enum EnumWithTooLargeElements : UInt8 {
case negativeOne = -1 // expected-error 2 {{negative integer '-1' overflows when stored into unsigned type 'UInt8'}}
Expand Down
4 changes: 4 additions & 0 deletions test/SILOptimizer/definite_init_diagnostics.swift
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
// RUN: %target-swift-frontend -emit-sil -primary-file %s -o /dev/null -verify
// RUN: %target-swift-frontend -emit-sil -enable-ownership-stripping-after-serialization -primary-file %s -o /dev/null -verify

// SWIFT_ENABLE_TENSORFLOW
// TODO(TF-799): Re-enable test after SR-11336 is fixed.
// XFAIL: *

import Swift

func markUsed<T>(_ t: T) {}
Expand Down
4 changes: 4 additions & 0 deletions test/SILOptimizer/definite_init_diagnostics_objc.swift
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
// RUN: %target-swift-frontend -emit-sil -sdk %S/../SILGen/Inputs %s -I %S/../SILGen/Inputs -enable-source-import -parse-stdlib -o /dev/null -verify -enable-ownership-stripping-after-serialization
// REQUIRES: objc_interop

// SWIFT_ENABLE_TENSORFLOW
// TODO(TF-799): Re-enable test after SR-11336 is fixed.
// XFAIL: *

import Swift
import gizmo

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
// RUN: %target-swift-frontend -emit-sil -disable-objc-attr-requires-foundation-module -verify %s
// RUN: %target-swift-frontend -emit-sil -disable-objc-attr-requires-foundation-module -verify %s -enable-ownership-stripping-after-serialization

// SWIFT_ENABLE_TENSORFLOW
// TODO(TF-799): Re-enable test after SR-11336 is fixed.
// XFAIL: *

// High-level tests that DI rejects certain invalid idioms for early
// return from initializers.

Expand Down
1 change: 1 addition & 0 deletions test/SILOptimizer/diagnostic_constant_propagation.swift
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
// References: <rdar://problem/29937936>,
// <https://bugs.swift.org/browse/SR-5964>

// SWIFT_ENABLE_TENSORFLOW
// TODO(TF-799): Re-enable RUN lines after SR-11336 is fixed.
// XFAIL: *

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@
//
// FIXME: <rdar://problem/39193272> A false negative that happens only in REPL

// SWIFT_ENABLE_TENSORFLOW
// TODO(TF-799): Re-enable test after SR-11336 is fixed.
// XFAIL: *

import StdlibUnittest

func testArithmeticOverflow_Int_64bit() {
Expand Down
4 changes: 4 additions & 0 deletions test/SILOptimizer/exclusivity_static_diagnostics.swift
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
// RUN: %target-swift-frontend -enforce-exclusivity=checked -swift-version 4 -emit-sil -primary-file %s -o /dev/null -verify
// RUN: %target-swift-frontend -enforce-exclusivity=checked -swift-version 4 -emit-sil -primary-file %s -o /dev/null -verify -enable-ownership-stripping-after-serialization

// SWIFT_ENABLE_TENSORFLOW
// TODO(TF-799): Re-enable test after SR-11336 is fixed.
// XFAIL: *

import Swift

func takesTwoInouts<T>(_ p1: inout T, _ p2: inout T) { }
Expand Down
4 changes: 4 additions & 0 deletions test/SILOptimizer/exclusivity_static_diagnostics_objc.swift
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
// RUN: %target-swift-frontend(mock-sdk: %clang-importer-sdk) -import-objc-header %S/Inputs/optional_closure_bridging.h -enforce-exclusivity=checked -swift-version 4 -emit-sil -primary-file %s -o /dev/null -verify -enable-ownership-stripping-after-serialization
// REQUIRES: objc_interop

// SWIFT_ENABLE_TENSORFLOW
// TODO(TF-799): Re-enable test after SR-11336 is fixed.
// XFAIL: *

import Foundation

class SomeClass {
Expand Down
4 changes: 4 additions & 0 deletions test/SILOptimizer/generalized_accessors.swift
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
//
// Tests for yield-once diagnostics emitted for generalized accessors.

// SWIFT_ENABLE_TENSORFLOW
// TODO(TF-799): Re-enable test after SR-11336 is fixed.
// XFAIL: *

struct TestNoYield {
var computed: Int {
_read {
Expand Down
4 changes: 4 additions & 0 deletions test/SILOptimizer/infinite_recursion.swift
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
// RUN: %target-swift-frontend -emit-sil -primary-file %s -o /dev/null -verify
// RUN: %target-swift-frontend -emit-sil -primary-file %s -o /dev/null -verify -enable-ownership-stripping-after-serialization

// SWIFT_ENABLE_TENSORFLOW
// TODO(TF-799): Re-enable test after SR-11336 is fixed.
// XFAIL: *

func a() { // expected-warning {{all paths through this function will call itself}}
a()
}
Expand Down
4 changes: 4 additions & 0 deletions test/SILOptimizer/invalid_escaping_captures.swift
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
// RUN: %target-swift-frontend -emit-sil %s -verify
// RUN: %target-swift-frontend -emit-sil %s -verify -enable-ownership-stripping-after-serialization

// SWIFT_ENABLE_TENSORFLOW
// TODO(TF-799): Re-enable test after SR-11336 is fixed.
// XFAIL: *

func takesEscaping(_: @escaping () -> ()) {}

func takesNonEscaping(_ fn: () -> ()) { fn() }
Expand Down
4 changes: 4 additions & 0 deletions test/SILOptimizer/mandatory_inlining.swift
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
// RUN: %target-swift-frontend -sil-verify-all -primary-file %s -emit-sil -o - -verify | %FileCheck %s
// RUN: %target-swift-frontend -sil-verify-all -primary-file %s -emit-sil -o - -verify -enable-ownership-stripping-after-serialization

// SWIFT_ENABLE_TENSORFLOW
// TODO(TF-799): Re-enable test after SR-11336 is fixed.
// XFAIL: *

// These tests are deliberately shallow, because I do not want to depend on the
// specifics of SIL generation, which might change for reasons unrelated to this
// pass
Expand Down
4 changes: 4 additions & 0 deletions test/SILOptimizer/noescape_param_exclusivity.swift
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
// RUN: %target-swift-frontend -emit-sil %s -verify
// RUN: %target-swift-frontend -emit-sil %s -verify -enable-ownership-stripping-after-serialization

// SWIFT_ENABLE_TENSORFLOW
// TODO(TF-799): Re-enable test after SR-11336 is fixed.
// XFAIL: *

func test0(a: (() -> ()) -> (), b: () -> ()) {
a(b) // expected-error {{passing a non-escaping function parameter 'b' to a call to a non-escaping function parameter can allow re-entrant modification of a variable}}
}
Expand Down
6 changes: 4 additions & 2 deletions test/SILOptimizer/pound_assert.swift
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
// RUN: %target-swift-frontend -enable-experimental-static-assert -emit-sil %s -verify
// RUN: %target-swift-frontend -enable-experimental-static-assert -enable-ownership-stripping-after-serialization -emit-sil %s -verify
// REQUIRES: asserts

// SWIFT_ENABLE_TENSORFLOW
// TODO(TF-799): Re-enable RUN line after SR-11336 is fixed.
// UN: %target-swift-frontend -enable-experimental-static-assert -enable-ownership-stripping-after-serialization -emit-sil %s -verify
// REQUIRES: asserts
// XFAIL: *

//===----------------------------------------------------------------------===//
// Basic function calls and control flow
Expand Down
13 changes: 5 additions & 8 deletions unittests/libInMemoryFrontend/InMemoryFrontendTests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,9 @@ class StreamDiagConsumer : public DiagnosticConsumer {
public:
StreamDiagConsumer(llvm::raw_ostream &OS) : OS(OS) {}

void
handleDiagnostic(SourceManager &SM, SourceLoc Loc, DiagnosticKind Kind,
StringRef FormatString,
ArrayRef<DiagnosticArgument> FormatArgs,
const DiagnosticInfo &Info,
const SourceLoc bufferIndirectlyCausingDiagnostic) override {
switch (Kind) {
void handleDiagnostic(SourceManager &SM,
const DiagnosticInfo &Info) override {
switch (Info.Kind) {
case DiagnosticKind::Error:
OS << "error: ";
break;
Expand All @@ -35,7 +31,8 @@ class StreamDiagConsumer : public DiagnosticConsumer {
OS << "remark: ";
break;
}
DiagnosticEngine::formatDiagnosticText(OS, FormatString, FormatArgs);
DiagnosticEngine::formatDiagnosticText(OS, Info.FormatString,
Info.FormatArgs);
}
};

Expand Down