Skip to content

[cxx-interop] Introduce APINotes file for C++ stdlib #68118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

egorzhdan
Copy link
Contributor

This adds an std.apinotes file that is installed into lib/swift/apinotes along with existing Darwin apinotes. This new file is installed on all platforms. It replaces a few special cases in the compiler for cmath and cstring functions.

This does not require the upcoming APINotes support for namespaces, however, this does require swiftlang/llvm-project#7309.

rdar://107572302

@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Aug 24, 2023
@hyp
Copy link
Contributor

hyp commented Aug 24, 2023

nice!

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Can you please make the associated change to apple/swift-installer-scripts to package this for Windows?

egorzhdan added a commit to swiftlang/swift-installer-scripts that referenced this pull request Aug 25, 2023
@egorzhdan
Copy link
Contributor Author

@compnerd yeap, just put up a PR: swiftlang/swift-installer-scripts#230

@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan
Copy link
Contributor Author

Please test with following PRs:

swiftlang/swift-installer-scripts#230

@swift-ci please build toolchain windows

@egorzhdan egorzhdan force-pushed the egorzhdan/cxxstdlib-apinotes branch from 8f16a1e to d386e81 Compare August 29, 2023 17:22
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan force-pushed the egorzhdan/cxxstdlib-apinotes branch from d386e81 to 3deacfd Compare August 29, 2023 19:09
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

1 similar comment
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

This adds an `std.apinotes` file that is installed into `lib/swift/apinotes` along with existing Darwin apinotes. This new file is installed on all platforms. It replaces a few special cases in the compiler for `cmath` and `cstring` functions.

This does not require the upcoming APINotes support for namespaces, however, this does require swiftlang/llvm-project#7309.

rdar://107572302
@egorzhdan egorzhdan force-pushed the egorzhdan/cxxstdlib-apinotes branch from 3deacfd to 9b7dbf2 Compare August 29, 2023 22:34
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan
Copy link
Contributor Author

Please test with following PRs:

swiftlang/swift-installer-scripts#230

@swift-ci please build toolchain windows

1 similar comment
@egorzhdan
Copy link
Contributor Author

Please test with following PRs:

swiftlang/swift-installer-scripts#230

@swift-ci please build toolchain windows

egorzhdan added a commit to swiftlang/swift-installer-scripts that referenced this pull request Aug 30, 2023
@egorzhdan
Copy link
Contributor Author

Please test with following PRs:

swiftlang/swift-installer-scripts#230

@swift-ci please build toolchain windows

@egorzhdan egorzhdan merged commit b40b1db into main Aug 30, 2023
@egorzhdan egorzhdan deleted the egorzhdan/cxxstdlib-apinotes branch August 30, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants