Replace generic basic_string overloads of StableHasher::combine with concrete ones.
#68193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith concrete ones. The generic `char_traits` implementation was deprecated and has since been removed from libc++ (https://reviews.llvm.org/D157058). When building with a libc++ that has it removed, the `basic_string<T>` overloads cause errors during template substitution.
|
@swift-ci please test |
compnerd
approved these changes
Aug 29, 2023
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic
char_traitsimplementation was deprecated and has since been removed from libc++ (https://reviews.llvm.org/D157058). When building with a libc++ that has it removed, the genericbasic_string<T>overloads cause errors during template substitution.