[WIP] Add swift-foundation to toolchain build #73403
Conversation
|
swiftlang/swift-foundation-icu#22 @swift-ci please build toolchain linux platform |
3 similar comments
|
swiftlang/swift-foundation-icu#22 @swift-ci please build toolchain linux platform |
|
swiftlang/swift-foundation-icu#22 @swift-ci please build toolchain linux platform |
|
swiftlang/swift-foundation-icu#22 @swift-ci please build toolchain linux platform |
| # has built. This needs to be done before Foundation can build | ||
| builder.begin_pipeline() | ||
|
|
||
| builder.add_product(products.foundation.SwiftFoundationICU, |
There was a problem hiding this comment.
I would suggest to avoid creating a new pipeline and piggyback instead on the first one -- effectively moving this line after the addition of the LibCurl product
| @@ -21,6 +22,74 @@ | |||
| from . import swift | |||
| from . import zlib | |||
|
|
|||
| class SwiftFoundationICU(cmake_product.CMakeProduct): | |||
There was a problem hiding this comment.
It would be best to have a separate python file for this class (e.g. foundation_icu.py)
|
swiftlang/swift-corelibs-foundation#4948 @swift-ci please build toolchain linux platform |
1 similar comment
|
swiftlang/swift-corelibs-foundation#4948 @swift-ci please build toolchain linux platform |
|
https://github.com/apple/swift-corelibs-foundation/pull/4948/files @swift-ci please build toolchain linux platform |
|
swiftlang/swift-corelibs-foundation#4948 @swift-ci please build toolchain linux platform |
jmschonfeld
force-pushed
the
swift-foundation-toolchain
branch
from
2d28001 to
27fbd5a
Compare
|
swiftlang/swift-foundation-icu#22 @swift-ci please build toolchain linux platform |
2 similar comments
|
swiftlang/swift-foundation-icu#22 @swift-ci please build toolchain linux platform |
|
swiftlang/swift-foundation-icu#22 @swift-ci please build toolchain linux platform |
|
apple/swift-collections#377 @swift-ci please build toolchain linux platform |
|
apple/swift-collections#378 @swift-ci please build toolchain linux platform |
3 similar comments
|
apple/swift-collections#378 @swift-ci please build toolchain linux platform |
|
apple/swift-collections#378 @swift-ci please build toolchain linux platform |
|
apple/swift-collections#378 @swift-ci please build toolchain linux platform |
|
apple/swift-collections#379 @swift-ci please build toolchain linux platform |
|
apple/swift-collections#379 @swift-ci please clean build toolchain linux platform |
2 similar comments
|
apple/swift-collections#379 @swift-ci please clean build toolchain linux platform |
|
apple/swift-collections#379 @swift-ci please clean build toolchain linux platform |
jmschonfeld
force-pushed
the
swift-foundation-toolchain
branch
from
50239d7 to
4e9d6d9
Compare
This is a WIP PR to add the swift-foundation set of projects to the toolchain build for use by swift-corelibs-foundation