Skip to content

[6.0] [Sema] Preserve compatibility for weak self with @_implicitSelfCapture #73997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2024
Merged

[6.0] [Sema] Preserve compatibility for weak self with @_implicitSelfCapture #73997

merged 1 commit into from
Jun 4, 2024

Conversation

hamishknight
Copy link
Contributor

6.0 cherry-pick of #73976

  • Explanation: Fixes a regression that would cause us to error on an implicit use of self in a weak self captured closure passed to an @_implicitSelfCapture parameter, e.g Task's initializer.
  • Scope: Adds a missed case to the warning downgrade logic for the invalid implicit self diagnostic.
  • Issue: rdar://128941797
  • Risk: Low, this strictly causes us to warn in more cases
  • Testing: Added tests to test suite
  • Reviewer: Cal Stephens

@hamishknight
[Sema] Preserve compatibility for weak self with `@_implicitSelfCap…
1458f3c 
…ture`

In 5.10 we warned on this:

```swift
func bar(@_implicitSelfCapture _ fn: @escaping () -> Void) {}

class C {
  func foo() {
    bar { [weak self] in
      foo()
    }
  }
}
```

But with the implicit self rework, this accidentally
became an error. Fix it to ensure we continue to
warn until Swift 6 mode.

rdar://128941797
@hamishknight hamishknight added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.0 labels May 30, 2024
@hamishknight hamishknight requested a review from hborla May 30, 2024 10:28
@hamishknight hamishknight requested a review from a team as a code owner May 30, 2024 10:28
@hamishknight hamishknight mentioned this pull request May 30, 2024
Merged
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight merged commit eb92e6e into swiftlang:release/6.0 Jun 4, 2024
5 checks passed
@hamishknight hamishknight deleted the implicit-self-fix-6.0 branch June 4, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov slavapestov approved these changes

@hborla hborla hborla approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamishknight @slavapestov @hborla