Skip to content

[cxx-interop] Print inline instead of static inline for template specializations #75804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

egorzhdan
Copy link
Contributor

This is a cherry-pick of #75418 for the main branch.

This fixes a number of test failures in reverse C++ interop.

Clang's behavior was changed in llvm/llvm-project#93873, and it no longer accepts the C++ headers that Swift generates.

rdar://132283247

…specializations

This fixes a number of test failures in reverse C++ interop.

Clang's behavior was changed in llvm/llvm-project#93873, and it no longer accepts the C++ headers that Swift generates.

rdar://132283247
@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Aug 9, 2024
@egorzhdan egorzhdan requested review from Xazax-hun and bnbarham August 9, 2024 15:03
@egorzhdan egorzhdan requested review from zoecarver and hyp as code owners August 9, 2024 15:03
@egorzhdan
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@Xazax-hun Xazax-hun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@egorzhdan egorzhdan enabled auto-merge August 9, 2024 15:07
@egorzhdan egorzhdan merged commit c3e067b into main Aug 9, 2024
5 checks passed
@egorzhdan egorzhdan deleted the egorzhdan/static-inline branch August 9, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants