-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[android] conditionally build DS2 for the Android SDK #76113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d9ba69
to
c32f1e7
Compare
@hjyamauchi would you mind having a look at this change? @shahmishal I believe you have some stake in |
hjyamauchi
reviewed
Aug 28, 2024
hjyamauchi
approved these changes
Aug 28, 2024
LGTM. Note the |
c32f1e7
to
cb9f813
Compare
@swift-ci please test |
cb9f813
to
64f181b
Compare
compnerd
reviewed
Sep 3, 2024
0594743
to
a6684fd
Compare
@swift-ci please smoke test |
compnerd
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditionally include the DS2debug server in the Android Swift SDK build. DS2 and its dependencies are only included when
build.ps1
is invoked with the-IncludeDS2
flag.This change is comprised of three primary parts:
flex
andbison
equivalents are required to build DS2.RegsGen2
host tool, specifying the previously unpackedwin_flex.exe
andwin_bison.exe
tools.Android.platform
directory.NOTE: the Android SDK isn't currently included in the installer build, so the ds2 binary only ends up in the output directory and not in any .msi file.
Test Plan
Build with and without ds2 included
Confirm the ds2 binary appears in the expected location only when
-IncludeDS2
is specified