[Driver] Always parse response files as GNU command line arguments #77080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
artemcm
approved these changes
Oct 17, 2024
clang parses response files in GNU mode, even on Windows except - If you explicitly pass `--rsp-quoting=windows` in the command line invocation or - If no `--rsp-quoting` is specified and clang is running `cl` mode, which is the case if clang is invoked as `cl` or `clang-cl`, which is the compatibility mode to Window’s `cl` compiler as far as I can tell. The Swift driver always outputs response files in GNU mode (swiftlang/swift-driver#1000). Since Swift does not need to support a compatibility mode with another compiler, there is no need for it to parse response files in Windows mode. We should unconditionally parse the response files in GNU mode.
ahoppen
force-pushed
the
gnu-response-file
branch
from
c3d3eb7 to
bb67c78
Compare
|
@swift-ci Please smoke test |
|
This PR also changed the old driver’s behavior to accept POSIX-style response files but CMake outputs Windows-style response files. Closing in favor of swiftlang/swift-driver#1716, which changes the driver to output Windows-style response files, keeping the frontend’s behavior the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang parses response files in GNU mode, even on Windows except
--rsp-quoting=windowsin the command line invocation or--rsp-quotingis specified and clang is runningclmode, which is the case if clang is invoked asclorclang-cl, which is the compatibility mode to Window’sclcompiler as far as I can tell.The Swift driver always outputs response files in GNU mode (swiftlang/swift-driver#1000).
Since Swift does not need to support a compatibility mode with another compiler, there is no need for it to parse response files in Windows mode. We should unconditionally parse the response files in GNU mode.