Skip to content

Frontend: re-serialise static library status #77861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

compnerd
Copy link
Member

When compiling the swiftmodule from the textual swift interface, ensure that we re-serialise the static or dynamic nature of the module. This is required for proper code generation where the static and dynamic linking is material to symbolic references. This also opens the possibility of optimizations on other platforms via internalisation of the symbols.

Fixes: #77756

@compnerd
Copy link
Member Author

@swift-ci please test

Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@compnerd compnerd force-pushed the static-serialisation branch from d7f3925 to e2c5139 Compare November 27, 2024 19:29
@compnerd
Copy link
Member Author

@swift-ci please test

When compiling the swiftmodule from the textual swift interface, ensure
that we re-serialise the static or dynamic nature of the module. This is
required for proper code generation where the static and dynamic linking
is material to symbolic references. This also opens the possibility of
optimizations on other platforms via internalisation of the symbols.

Fixes: swiftlang#77756
@compnerd compnerd force-pushed the static-serialisation branch from e2c5139 to b660d20 Compare November 27, 2024 22:25
@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Dec 2, 2024

@swift-ci please test Windows platfom

@compnerd
Copy link
Member Author

compnerd commented Dec 2, 2024

@swift-ci please test Windows platform

@compnerd compnerd merged commit 694e105 into swiftlang:main Dec 2, 2024
5 checks passed
@compnerd compnerd deleted the static-serialisation branch December 2, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

swiftinterface compilation does not re-serialise static library builds
3 participants