Skip to content

utils: drop cmake version check #78000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2024
Merged

utils: drop cmake version check #78000

merged 1 commit into from
Dec 6, 2024

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Dec 6, 2024

There is no guarantee that cmake is available in the path. CMake may be provided through VS or the VS Build Tools, in which case, you must be in a VSDevCmd environment to invoke cmake. This adds quite a bit of complexity for little gain as the projects will check of the minimum version required (cmake_minimum_required).

There is no guarantee that `cmake` is available in the path. CMake may
be provided through VS or the VS Build Tools, in which case, you must be
in a VSDevCmd environment to invoke `cmake`. This adds quite a bit of
complexity for little gain as the projects will check of the minimum
version required (`cmake_minimum_required`).
@compnerd
Copy link
Member Author

compnerd commented Dec 6, 2024

CC: @weliveindetail @hjyamauchi

@compnerd
Copy link
Member Author

compnerd commented Dec 6, 2024

@swift-ci please smoke test

@weliveindetail
Copy link
Member

weliveindetail commented Dec 6, 2024

Good point. I have no strong opinion on it, but if we remove this check, we might want to raise the cmake_minimum_required version in the top-level swift project from 3.19 to 3.28, because this is what swift-inspect requires

cmake_minimum_required(VERSION 3.28)

FYI: We did have version checks like this before #77948 here: 6ca7ed6

@compnerd
Copy link
Member Author

compnerd commented Dec 6, 2024

@weliveindetail swift-inspect is built as a standalone project, not part of the Swift toolchain build, so the top level CMake version check doesn't impact it.

Yeah, I think that I would rather make things unconditional if possible.

@weliveindetail
Copy link
Member

weliveindetail commented Dec 6, 2024

swift-inspect is built as a standalone project, not part of the Swift toolchain build, so the top level CMake version check doesn't impact it

@compnerd Yes, just saying that it's suboptimal to bail out so late in the build process due to an insufficient CMake version. That was the intention of the early check, but ithat's nice-to-have. If it causes issues, let's drop it.

@compnerd compnerd merged commit f1f1051 into swiftlang:main Dec 6, 2024
3 checks passed
@compnerd compnerd deleted the yolo branch December 6, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants