[windows][toolchain] Restrict the sanitizer build to x64 and disable the legacy path for builtins #78011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
reviewed
Dec 6, 2024
| @@ -2774,7 +2774,9 @@ if (-not $SkipBuild) { | |||
|
|
|||
| $InstallTo = "$($HostArch.ToolchainInstallRoot)\usr" | |||
| foreach ($Arch in $WindowsSDKArchs) { | |||
| Invoke-BuildStep Build-Sanitizers Windows $Arch $InstallTo | |||
| if ($Arch.ShortName = "x64") { | |||
There was a problem hiding this comment.
Can the sanitizers work on x86 as well?
There was a problem hiding this comment.
Yes, but we didn't test it and since the arm64 test was negative, it seemed reasonable to stick to what we know works.
|
@swift-ci please test |
|
Closing this PR. It landed as part of #77770 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, on Windows arm64 ASAN isn't working yet. These two changes should have a slightly positive effect on the CI runtime.