Better handle status updates for build tasks #1539
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For tasks in the "build" group like those provided by the extension, we can ignore parsing the build output for completion and instead wait for the fallback of waiting for the task to end. Issue: swiftlang#1477
award999
requested review from
plemarquand
and removed request for
adam-fowler and
0xTim
plemarquand
reviewed
May 13, 2025
| @@ -121,7 +124,8 @@ export class SwiftBuildStatus implements vscode.Disposable { | |||
| const lines = sanitizedData.split(/\r\n|\n|\r/gm).reverse(); | |||
| for (const line of lines) { | |||
| if (checkIfBuildComplete(line)) { | |||
| return true; | |||
| update(name); | |||
| return !isBuildTask && true; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For tasks in the "build" group like those provided by the extension, we can ignore parsing the build output for completion and instead wait for the fallback of waiting for the task to end.
Issue: #1477