Skip to content

Add diagnostics for those who build with WASI command line ABI #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2022
Merged

Add diagnostics for those who build with WASI command line ABI #202

merged 1 commit into from
Jul 31, 2022

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Jul 31, 2022 •
edited
Loading

It's hard to find the root cause of crash when building with WASI command ABI

Mitigate unfortunate situations like #199

@kateinoigakukun kateinoigakukun force-pushed the katei/diagnose-wasi-command-line branch from 35005ef to 2885304 Compare July 31, 2022 14:52
@github-actions
Copy link

github-actions bot commented Jul 31, 2022 •
edited
Loading

Time Change: -706ms (3%)

Total Time: 20,340ms

Test name Duration Change
Serialization/Write JavaScript string directly 452ms -32ms (7%) ✅
View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 436ms +1ms
Serialization/Swift Int to JavaScript 6,668ms -216ms (3%)
Serialization/Swift String to JavaScript 6,679ms -182ms (2%)
Object heap/Increment and decrement RC 6,105ms -278ms (4%)

@kateinoigakukun kateinoigakukun requested a review from a team July 31, 2022 15:04
MaxDesiatov
MaxDesiatov approved these changes Jul 31, 2022
View reviewed changes
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kateinoigakukun kateinoigakukun merged commit 8478665 into main Jul 31, 2022
@kateinoigakukun kateinoigakukun deleted the katei/diagnose-wasi-command-line branch July 31, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kateinoigakukun @MaxDesiatov