-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Serializer] [JsonStreamer] Add streaming JSON documentation #20486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 7.3
Are you sure you want to change the base?
Conversation
592f9aa
to
afa08c8
Compare
The remaining failure is due to the fact that the https://github.com/symfony-tools/symfony-application application does not have the Should we create it? Or should we add the issue to the baseline? Or maybe commenting that configuration? |
Hi @mtarld. Thanks a lot for starting this and providing so much valuable documentation early in the development phase! Before reviewing the whole document, we must think about the position of the component in the documentation. We've mostly stopped using the I think the best way would be to move this article to Something that might also be interesting is adding a |
The documentation requires update, because the component and it's contents has been renamed - see symfony/symfony#59863 |
Can you provide minimum code required to use the component in custom service inside Symfony project? Could be also useful for "New in Symfony 7.3" blog series. I tried following the documentation (with updated names), but I get |
Hey @SirRFI , thanks for keeping track of it. I'm aware of these points yes! 🙂 I'm really busy these days, but as soon as I have time, I'll update this PR (containing your suggestions) - it's part of my top priorities. |
afa08c8
to
749bd5d
Compare
749bd5d
to
0e63875
Compare
0e63875
to
fb3e6c6
Compare
Fixes #20461, #20708, #20676, #20598, #20572