Skip to content

[Icons] <twig:UX:icon .../> casing issue #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kbond opened this issue Mar 25, 2024 · 2 comments · Fixed by #1659
Closed

[Icons] <twig:UX:icon .../> casing issue #1657

kbond opened this issue Mar 25, 2024 · 2 comments · Fixed by #1659

Comments

@kbond
Copy link
Member

kbond commented Mar 25, 2024

ux.symfony.com/icons shows <twig:ux:icon .../> (lowercase UX). Considering the way we hijack rendering the component via an event, can we make case insensitive? I admit, uppercasing UX is a bit of a pain when writing manually.

@smnandre
Copy link
Member

We can! ...

Lowercase would just be "supported" or we make it the "official" case ?

We should use the same as much as possible, as i'm not sure of the implications in term of caching, opcode, etc.. :|

@kbond
Copy link
Member Author

kbond commented Mar 25, 2024

Yes, we should definitely be consistent in docs/code, and of course, projects should be consistent in their usage.

I'm not sure on the official case... I think I'm leaning towards <twig:ux:icon .../> (lowercase).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants