[TwigComponent] Fix debug command #2088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yceruto
commented
Aug 20, 2024
yceruto
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| Issues | Fix #2087 |
| License | MIT |
carsonbot
added
Bug
smnandre
reviewed
Aug 20, 2024
| @@ -1634,7 +1634,7 @@ Anonymous Components | |||
|
|
|||
| .. versionadded:: 2.20 | |||
|
|
|||
| The bundle convention for Anonymous components was added in TwigComponents 2.18. | |||
| The bundle convention for Anonymous components was added in TwigComponents 2.20. | |||
There was a problem hiding this comment.
I'm jumping on the occasion... what do you think about something like "The automatic registration of Anonymouns components from Bundle" ?
Just a suggestion, feel free to ignore if you prefer the current one :)
There was a problem hiding this comment.
Simon just saw it, feel free to improve it in a new PR, LGTM 👍
smnandre
approved these changes
Aug 20, 2024
carsonbot
added
Status: Reviewed
|
Thanks Yonel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.