Fixed typo in links to Symfony UX repo #2193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! But note that only the I'm merging, and ask to the appropriate persons for |
I fixed typo in the links to Symfony UX repo (before: symfony/symfony-ux). Note: I wasn't able to deal with the "version" variable.
|
Thank you @sblum51. |
Kocal
added a commit
that referenced
this pull request
Sep 23, 2024
This PR was merged into the 2.x branch. Discussion ---------- [Doc] Fix some links in UX Map docs | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Issues | - | License | MIT Related to #2193. The `{version}` placeholder only works for Symfony Docs and I'm not sure it can be extended to also work on UX. So, let's just hardcode the `2.x` version number because this is fine. Commits ------- b234d43 [Doc] Fix some links in UX Map docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed typo in the links to Symfony UX repo (before: symfony/symfony-ux).
Note: I wasn't able to deal with the "version" variable.
Before : https://github.com/symfony/symfony-ux/blob/4.4/src/Map/src/Bridge/Leaflet/README.md (404)
Now : https://github.com/symfony/ux/blob/2.x/src/Map/src/Bridge/Leaflet/README.md